Skip to content

[SYCL][Graph] Fix E2E disabled RUN lines #14902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Aug 1, 2024

We were using the x prefix to the RUN lit command to comment out a RUN check. However, LIT still detects this as a RUN command, which illustrated in a CI fail of this test recently https://github.com/intel/llvm/actions/runs/10198164930/job/28215254220

Fixed by changing xRUN to RUNx which I've verified locally is not detected as a RUN command by LIT, and can be used to comment the RUN command out.

Relates to #14473

@EwanC EwanC requested a review from a team as a code owner August 1, 2024 15:35
@EwanC EwanC temporarily deployed to WindowsCILock August 1, 2024 15:37 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock August 1, 2024 16:21 — with GitHub Actions Inactive
@ayylol
Copy link
Contributor

ayylol commented Aug 1, 2024

If you'd like to keep the line commented rather than deleting it you could replace the xRUN with RUNx, that seems to not be picked up by lit correctly.
For example like this test: https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp#L3

We were using the `x` prefix to the `RUN` lit command to comment out a `RUN`
check. However, LIT still detects this as a `RUN` command, which illustrated
in a CI fail of this test recently https://github.com/intel/llvm/actions/runs/10198164930/job/28215254220

Fixed by changing `xRUN` to `RUNx` which I've verified locally is not detected as a
`RUN` command by LIT, and can be used to comment the `RUN` command out.

Relates to intel#14473
@EwanC EwanC temporarily deployed to WindowsCILock August 2, 2024 08:30 — with GitHub Actions Inactive
@EwanC EwanC changed the title [SYCL][Graph] Remove E2E xrun lines. [SYCL][Graph] Fix E2E disabled RUN lines Aug 2, 2024
@EwanC
Copy link
Contributor Author

EwanC commented Aug 2, 2024

If you'd like to keep the line commented rather than deleting it you could replace the xRUN with RUNx, that seems to not be picked up by lit correctly. For example like this test: https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp#L3

Great tip thanks, verified that locally and updated the PR to that

@EwanC EwanC temporarily deployed to WindowsCILock August 2, 2024 08:43 — with GitHub Actions Inactive
@EwanC
Copy link
Contributor Author

EwanC commented Aug 5, 2024

@intel/llvm-gatekeepers The CI fail is from the problematic HIP runner. This PR disables a E2E RUN line that is guarded by %if level_zero, so should be okay to merge.

@steffenlarsen steffenlarsen merged commit ffd443c into intel:sycl Aug 6, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants