Skip to content

[SYCL][COMPAT][E2E] Removes std++20 usage from syclcompat e2e tests #14916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Aug 2, 2024

Removes c++20 features from the e2e tests to avoid introducing c++20 in SYCLcompat by accident

@Alcpz Alcpz requested a review from a team as a code owner August 2, 2024 10:57
@Alcpz Alcpz temporarily deployed to WindowsCILock August 2, 2024 10:57 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock August 2, 2024 11:10 — with GitHub Actions Inactive
@Alcpz Alcpz closed this Aug 19, 2024
@Alcpz Alcpz reopened this Aug 19, 2024
@Alcpz Alcpz temporarily deployed to WindowsCILock August 19, 2024 12:12 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock August 19, 2024 12:25 — with GitHub Actions Inactive
@Alcpz
Copy link
Contributor Author

Alcpz commented Aug 19, 2024

@intel/llvm-gatekeepers This is ready to merge. The only pending check is the AWS CUDA that I think (?) was removed. Tests passing for NVIDIA/CUDA which target the same backend.

@aelovikov-intel aelovikov-intel merged commit fd47adf into sycl Aug 19, 2024
26 of 28 checks passed
@aelovikov-intel aelovikov-intel deleted the Alcpz/syclcompat-std20-removal branch August 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants