[SYCL][E2E] Mark free_function tests unsupported on HIP #14917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
approved these changes
Aug 2, 2024
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This is trivial enough that maybe it can be merged without CI finishing? What do you think @intel/llvm-gatekeepers? |
|
Looks like CI finished except for the stalled HIP runner, this is fine given you are marking a test that won't run on HIP anyway. |
|
FYI, this will be fixed with this PR. I am just didn't find time to complete it, but will update it with a unittest in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests currently fail on AMD devices. To enable them, sycl_ext_oneapi_free_function_kernels.asciidoc needs to be investigated how to make it work for HIP backend.