Skip to content

[SYCL][InvokeSimd][E2E] Remove incorrect test #14957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Aug 5, 2024

The test claims only scalars are allowed as per the spec but that's not true, we allow trivially copyable data types as per here:

Each argument in the args parameter pack must be an arithmetic type, a trivially copyable type wrapped in a sycl::ext::oneapi::experimental::uniform, or a std::tuple of these types

This part of the spec is already tested here, and the test won't pass because of a GPU driver issue, the same thing is tested here and here.

Just remove the test because the expected failure is not expected, and the passing case is covered by other tests.

Closes: #14642

@sarnex sarnex temporarily deployed to WindowsCILock August 5, 2024 18:38 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review August 5, 2024 19:04
@sarnex sarnex requested a review from a team as a code owner August 5, 2024 19:04
@sarnex sarnex temporarily deployed to WindowsCILock August 5, 2024 19:42 — with GitHub Actions Inactive
@sarnex sarnex merged commit 0382be0 into intel:sycl Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test SYCL :: InvokeSimd/Spec/clang_run_error/accessor_argument.cpp failing on GPU
2 participants