[SYCL] Fix Kernel Compiler OpenCLC_Supports_Extension #14959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional parameter VersionPtr is nullptr by default. But, the code assumes it is a valid pointer. So, the fix is to guard with an "if" conditional phrase.
aelovikov-intel
requested changes
Aug 5, 2024
Added tests ext_oneapi_support_cl_extension() without versionPtr parameter set. |
aelovikov-intel
approved these changes
Aug 6, 2024
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
The optional parameter `VersionPtr` is `nullptr` by default. But, the code assumes it is a valid pointer. So, the fix is to guard with an `if` conditional phrase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional parameter
VersionPtrisnullptrby default. But, the code assumes it is a valid pointer.So, the fix is to guard with an
ifconditional phrase.