Skip to content

[SYCL][Driver] Support -fsycl-allow-device-dependencies on clang-cl #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2024
Merged

[SYCL][Driver] Support -fsycl-allow-device-dependencies on clang-cl #14978

merged 4 commits into from
Aug 7, 2024

Conversation

LU-JOHN
Copy link
Contributor

@LU-JOHN LU-JOHN commented Aug 6, 2024

Accept -fsycl-allow-device-dependencies with clang-cl.

  1. Also add testing for -fno-sycl-allow-device-dependencies.
  2. Remove RUNx commands that were in preparation for connecting -support-dynamic-linking to -shared. -support-dynamic-linking will only be connected to -fsycl-allow-device-dependencies.
  3. Rename CHECK names to use "SADD" (SYCL Allow Device Dependencies) instead of "SHARED".

@LU-JOHN LU-JOHN requested a review from a team as a code owner August 6, 2024 18:27
@mdtoguchi mdtoguchi changed the title [SYCL][DRIVER} Support -fsycl-allow-device-dependencies on clang-cl [SYCL][Driver] Support -fsycl-allow-device-dependencies on clang-cl Aug 6, 2024
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@LU-JOHN
Copy link
Contributor Author

LU-JOHN commented Aug 6, 2024

@intel/llvm-gatekeepers Please merge.

@steffenlarsen steffenlarsen merged commit 7659c0c into intel:sycl Aug 7, 2024
13 checks passed
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
…ntel#14978)

Accept -fsycl-allow-device-dependencies with clang-cl.

1. Also add testing for -fno-sycl-allow-device-dependencies.
2. Remove RUNx commands that were in preparation for connecting
-support-dynamic-linking to -shared. -support-dynamic-linking will only
be connected to -fsycl-allow-device-dependencies.
3. Rename CHECK names to use "SADD" (SYCL Allow Device Dependencies)
instead of "SHARED".

---------

Signed-off-by: Lu, John <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants