[SYCL][Driver][NFC] Reorganize SYCL based options #14979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL based options in the Options.td table were a bit scattered about. Reorganize the options to be in a more centralized area, allowing for a more general adaptation of using sycl_Group. Items within sycl_Group will automatically be allowed for Windows and Linux command lines. Some test cleanup involving some expected warnings have also been addressed, either due by proper enabling for Windows or improper warning expectations.
| @@ -187,7 +187,8 @@ def opencl_Group : OptionGroup<"<opencl group>">, Group<f_Group>, | |||
| DocName<"OpenCL options">; | |||
|
|
|||
| def sycl_Group : OptionGroup<"<SYCL group>">, Group<f_Group>, | |||
There was a problem hiding this comment.
Why is Group<f_Group> needed here?
Will DocName<"SYCL options"> override the DocName defined in Group<f_Group>
def f_Group : OptionGroup<"<f group>">, Group<CompileOnly_Group>,
DocName<"Target-independent compilation options">;
Also, f_Group has CompileOnly_Group, but some of the options in sycl_Group are link time options.
There was a problem hiding this comment.
The use of f_Group here is more in line with existing usage for offloading specific options such as cuda_Group and offload_Group. Not all options used are specific to the compilation phase, but are part of the overall compilation to create the device binary.
I checked the generated documentation files, and sycl_Group does override f_Group in regards to the DocName
srividya-sundaram
approved these changes
Aug 8, 2024
|
@intel/llvm-gatekeepers, this looks ready for merge, please take a look - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL based options in the Options.td table were a bit scattered about. Reorganize the options to be in a more centralized area, allowing for a more general adaptation of using sycl_Group. Items within sycl_Group will automatically be allowed for Windows and Linux command lines.
Some test cleanup involving some expected warnings have also been addressed, either due by proper enabling for Windows or improper warning expectations.