[UR][L0] Enable Immediate Command List by default given Intel DG2 #15031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nrspruit sorry i just happened to see notice this PR and I know it's a still draft, but since this looks like a DG2 specific change, DG2 testing isn't run in precommit besides trivial matrix tests. if you want to do full DG2 testing we need to run postcommit as part of PR testing, which you can do by creating a branch in intel/llvm prefixed with |
nrspruit
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Thanks, looks like postcommit is running there as expected! |
nrspruit
force-pushed
the
dg2_immediate_default
branch
from
d461bc8 to
3dade8d
Compare
nrspruit
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
nrspruit
force-pushed
the
dg2_immediate_default
branch
from
3dade8d to
74aea90
Compare
omarahmed1111
force-pushed
the
dg2_immediate_default
branch
from
74aea90 to
fbab989
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
approved these changes
Aug 27, 2024
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
dg2_immediate_default
branch
from
fbab989 to
dad88a9
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
-pre-commit PR for oneapi-src/unified-runtime#1951 Signed-off-by: Neil R. Spruit <[email protected]>
omarahmed1111
force-pushed
the
dg2_immediate_default
branch
from
dad88a9 to
12a8296
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This will be included in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-pre-commit PR for oneapi-src/unified-runtime#1951