Skip to content

[SYCL][Graph] Fix missing includes for e2e tests using reduction #15115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2024
Merged

[SYCL][Graph] Fix missing includes for e2e tests using reduction #15115

merged 2 commits into from
Aug 20, 2024

Conversation

reble
Copy link
Contributor

@reble reble commented Aug 16, 2024

Issue resulting of incomplete finer grained includes #13846

@reble reble requested a review from a team as a code owner August 16, 2024 19:11
@reble reble temporarily deployed to WindowsCILock August 16, 2024 19:11 — with GitHub Actions Inactive
@reble reble temporarily deployed to WindowsCILock August 16, 2024 19:24 — with GitHub Actions Inactive
@EwanC
Copy link
Contributor

EwanC commented Aug 19, 2024

We only have 3 reduction tests in Graph/Inputs, so I think we could just introduce this header for those files rather than bringing it in for every test.

@reble reble temporarily deployed to WindowsCILock August 19, 2024 16:54 — with GitHub Actions Inactive
@reble reble temporarily deployed to WindowsCILock August 19, 2024 17:08 — with GitHub Actions Inactive
@EwanC
Copy link
Contributor

EwanC commented Aug 20, 2024

@intel/llvm-gatekeepers This is good to merge

@sommerlukas sommerlukas merged commit ad6ffcd into intel:sycl Aug 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reble @EwanC @sommerlukas