Skip to content

[GHA] Uplift Linux IGC Dev RT version to igc-dev-3c5dac9 #15125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

bb-sycl
Copy link
Contributor

@bb-sycl bb-sycl commented Aug 19, 2024

Scheduled igc dev drivers uplift

@bb-sycl bb-sycl requested a review from a team as a code owner August 19, 2024 03:03
@sarnex sarnex merged commit fdcf125 into sycl Aug 26, 2024
15 checks passed
@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

@jsji Any idea on this docker postcommit fail?

https://github.com/intel/llvm/actions/runs/10561303761/job/29259192728

ERROR: failed to solve: process "/bin/sh -c install_driver_opt=\"dependencies.json dependencies-igc-dev.json --use-dev-igc\";     GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all" did not complete successfully: exit code: 9
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c install_driver_opt=\"dependencies.json dependencies-igc-dev.json --use-dev-igc\";     GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all" did not complete successfully: exit code: 9

@jsji
Copy link
Contributor

jsji commented Aug 26, 2024

@jsji Any idea on this docker postcommit fail?

https://github.com/intel/llvm/actions/runs/10561303761/job/29259192728

ERROR: failed to solve: process "/bin/sh -c install_driver_opt=\"dependencies.json dependencies-igc-dev.json --use-dev-igc\";     GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all" did not complete successfully: exit code: 9
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c install_driver_opt=\"dependencies.json dependencies-igc-dev.json --use-dev-igc\";     GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all" did not complete successfully: exit code: 9

This is known limitation -- if the dev igc version we use (after uplift) are too old (more than 1 week old), we won't be able to download it from GitHub CI anymore, then it will fail.

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

@jsji Thanks, I don't need to revert the PR right, this version just wont be used?

Could we update the bot to close any PRs after the IGC max retention days passes?

@jsji
Copy link
Contributor

jsji commented Aug 26, 2024

@jsji Thanks, I don't need to revert the PR right, this version just wont be used?

Yes, we don't. We will still use the old docker with very old version, until we uplift with new one succesfully.

Could we update the bot to close any PRs after the IGC max retention days passes?

We can do that, but it probably better if we could merge the PR when it is green, don't let it pass the date.

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

We can do that, but it probably better if we could merge the PR when it is green, don't let it pass the date.

Sure, I was out last week and it seems nobody else looks at these so I guess whoops :)

@jsji
Copy link
Contributor

jsji commented Aug 26, 2024

We can do that, but it probably better if we could merge the PR when it is green, don't let it pass the date.

Sure, I was out last week and it seems nobody else looks at these so I guess whoops :)

Yeah, not your problem at all. Just wondering any other way that we can make sure we merge it on time?

@aelovikov-intel aelovikov-intel deleted the ci/update_gpu_driver-linux-igc-dev-3c5dac9 branch August 26, 2024 15:33
@aelovikov-intel
Copy link
Contributor

Yeah, not your problem at all. Just wondering any other way that we can make sure we merge it on time?

Make matrix/esimd teams codeowners for this file as they're the most interested in dev IGC testing. Ensure that they look into the failures in such PRs first, because I have an impression those are the tests that usually fail (might be wrong here).

@sarnex
Copy link
Contributor

sarnex commented Aug 26, 2024

I think you're right and I talked with Jinsong offline and we're gonna do that, thanks

@jsji
Copy link
Contributor

jsji commented Aug 26, 2024

PR fo codeowner update: #15193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants