[SYCL][NATIVECPU] Fix linker errors for WorkGroup collective functions #15144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
coldav
approved these changes
Aug 23, 2024
uwedolinsky
reviewed
Aug 23, 2024
| } else { | ||
| printf("test failed!\n"); | ||
| } | ||
| assert(fails == 0); |
There was a problem hiding this comment.
The assert might get compiled away so it's probably better to return fails to not lose the error.
There was a problem hiding this comment.
That's done, thank you
mdtoguchi
approved these changes
Aug 23, 2024
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @intel/llvm-reviewers-runtime, after #15142 the ownership of |
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 3, 2024
uwedolinsky
approved these changes
Sep 4, 2024
|
@intel/llvm-gatekeepers this looks ready to merge, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some link-time error related to WorkGroup collective functions:
_Float16data type and the__spirv_GroupBroadcastfunction, which leads toundefined referencelinker errors.clang-offload-depsis not emitted by the driver: the call introduced anllvm.usedarray, which contained function pointers to the kernels which prevented eliminating those functions from the module even when they are not needed anymore (due to inlining). This lead to otherundefined referencelinker errors for WorkGroup collectives.