Skip to content

[SYCL][E2E] Reenable old tests #15146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Aug 20, 2024

This commit reenables a selection of tests that have previously been disabled, most for different reasons.

Additionally, the subbuffer test still seems to fail on Gen12 OpenCL, so this commit adds a comment with a link to the GH issue.

This commit reenables a selection of tests that have previously been
disabled, most for different reasons.

Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen marked this pull request as ready for review August 22, 2024 05:30
@steffenlarsen steffenlarsen requested a review from a team as a code owner August 22, 2024 05:30
@@ -1,6 +1,7 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// See https://github.com/intel/llvm/issues/15151
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly reenabling. I'm okay with it, just noting it in case it was involuntarily added to this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally tried to reenable it, but it seemed to still fail on Gen12. I will make this clear in the description of the PR.

@steffenlarsen steffenlarsen merged commit d1f2699 into intel:sycl Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants