[SYCL] Disable clang pedantic diagnostics in header/footer #15171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
changed the title
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
elizabethandrews
approved these changes
Aug 23, 2024
|
@intel/llvm-gatekeepers, this is ready for merge. The test failures seem unrelated to my changes. |
smanna12
approved these changes
Aug 23, 2024
This looks weird and I'm not aware of any issues with gen12 runners. I'm re-running the failed job. |
Thanks! Looks finished? |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
When -Wreserved-identifer or -Wold-style-cast is enabled, some of the constructs used in integration headers and footers for device_globals and host_pipes trigger a diagnostic. This change adds a pragma to the generated files that suppress the diagnostic prior to the construct and reenabled the diagnostic after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -Wreserved-identifer or -Wold-style-cast is enabled, some of the constructs used in
integration headers and footers for device_globals and host_pipes trigger a diagnostic.
This change adds a pragma to the generated files that suppress the diagnostic prior to
the construct and reenabled the diagnostic after.