[NFCI] Refactor sycl::vec's variadic ctor
#15180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think previous implementation was based on C++14 or even C++11 standard. We can do better now.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Aug 22, 2024
Comment on lines
+192
to
+195
| // FIXME: Swizzle's `operator[]` for expression trees seems to be broken | ||
| // and returns values of the underlying vector of some of the operands. On | ||
| // the other hand, `getValue()` gives correct results. This can be changed | ||
| // to using `operator[]` once the bug is fixed. |
There was a problem hiding this comment.
That seems to be broken at least as far back as 2024.1: https://godbolt.org/z/9Kz953sfn
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
approved these changes
Aug 23, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Aug 23, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
CUDA failure is an infrastructure issue, the change isn't CUDA-specific, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think previous implementation was based on C++14 or even C++11 standard. We can do better now.