[SYCL][Graph] Make calling begin_recording repeatedly an error #15192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling begin_recording on a recording queue is now always an error - Update spec, implementation and unit tests
EwanC
approved these changes
Aug 27, 2024
|
@intel/llvm-gatekeepers This should be good to merge if possible, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since future features may add more properties/state to queue recording it is now an error to call
begin_recording()on the same queue more than once, rather than a no-op. This is particularly relevant in scenarios where a recording queue is shared between multiple threads. Applications are now encouraged to manage queue state from a single thread rather than freely callbegin/end_recording()from any thread.