[SYCL] Fix -Wstring-concatenation in integration headers #15197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sentinel value added in intel#15175 fixed the problem of empty arrays, but for non-empty arrays was just concatenated to the last valid value. This produced warnings when compiling SYCL applications, and also meant that there is no sentinel value in the non-empty arrays.
|
Ping @premanandrao |
|
@intel/llvm-gatekeepers, could you please start the CI? |
|
@intel/llvm-gatekeepers, this PR seems ready, could you please merge? |
smanna12
approved these changes
Sep 3, 2024
|
@intel/llvm-gatekeepers, there is some urgency with this change as it needs to go into a product branch. |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
A sentinel value added in intel#15175 fixed the problem of empty arrays, but for non-empty arrays was just concatenated to the last valid value. This produced warnings when compiling SYCL applications, and also meant that there is no sentinel value in the non-empty arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sentinel value added in #15175 fixed the problem of empty arrays, but for non-empty arrays was just concatenated to the last valid value. This produced warnings when compiling SYCL applications, and also meant that there is no sentinel value in the non-empty arrays.