-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Enhance PI tracing with printing output (pointer) arguments #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artur Gainullin <[email protected]>
19bc7f8
to
e58f60b
Compare
@againull, ping. |
@againull, ping^2. |
@againull, please, resolve merge conflicts. |
* Move printers to sources directory to reduce number of public APIs * Print "nullptr" if pointer is nullptr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add some test to verify new traces?
It was committed to this branch by mistake This reverts commit ef6d325.
@againull, please, resolve merge conflicts and address comments from Vladimir. |
Sorry, I will address comments by the end of this week. |
* Add tests to check all printers * Other small fixes
@@ -0,0 +1,55 @@ | |||
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER | |||
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md#test-dpc-toolchain the tests should go to LLVM* test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed tests. Prepared PR intel/llvm-test-suite#64 to add tests to llvm-test-suite
@againull, please, resolve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be nice to add a small test though.
Sergey, test is going to be added to the llvm-test-suite intel/llvm-test-suite#64 |
Signed-off-by: Artur Gainullin [email protected]