Skip to content

[SYCL] Enhance PI tracing with printing output (pointer) arguments #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 8, 2020

Conversation

againull
Copy link
Contributor

Signed-off-by: Artur Gainullin [email protected]

@againull againull force-pushed the enhanced_pi_tracing branch from 19bc7f8 to e58f60b Compare April 14, 2020 22:49
@bader bader requested a review from AlexeySachkov April 16, 2020 11:07
@bader
Copy link
Contributor

bader commented May 7, 2020

@againull, ping.

@bader
Copy link
Contributor

bader commented May 17, 2020

@againull, ping^2.

@bader bader removed their request for review July 9, 2020 18:57
@bader
Copy link
Contributor

bader commented Sep 24, 2020

@againull, please, resolve merge conflicts.

* Move printers to sources directory to reduce number of public APIs
* Print "nullptr" if pointer is nullptr
@againull againull requested a review from a team as a code owner September 25, 2020 00:04
Copy link
Contributor

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add some test to verify new traces?

@againull againull requested a review from vladimirlaz October 14, 2020 04:56
@bader
Copy link
Contributor

bader commented Nov 24, 2020

@againull, please, resolve merge conflicts and address comments from Vladimir.

@againull
Copy link
Contributor Author

@againull, please, resolve merge conflicts and address comments from Vladimir.

Sorry, I will address comments by the end of this week.

@againull againull requested a review from vladimirlaz December 3, 2020 08:20
@bader bader requested a review from romanovvlad December 3, 2020 10:47
@bader bader changed the title [SYCL] enhanced PI tracing to print output (pointer) arguments [SYCL] Enhance PI tracing with printing output (pointer) arguments Dec 3, 2020
@@ -0,0 +1,55 @@
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed tests. Prepared PR intel/llvm-test-suite#64 to add tests to llvm-test-suite

@bader
Copy link
Contributor

bader commented Dec 6, 2020

@againull, please, resolve merge conflicts.
@vladimirlaz, please, review that requested changes were applied.

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice to add a small test though.

@bader bader merged commit 19f5ad6 into intel:sycl Dec 8, 2020
@againull
Copy link
Contributor Author

againull commented Dec 9, 2020

LGTM, it would be nice to add a small test though.

Sergey, test is going to be added to the llvm-test-suite intel/llvm-test-suite#64

@againull againull deleted the enhanced_pi_tracing branch December 3, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants