-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Graph] Support sycl_ext_oneapi_raw_kernel_arg #15252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50556d7
to
fd7b049
Compare
fd7b049
to
ca81bfd
Compare
ca81bfd
to
49078b2
Compare
49078b2
to
6a14f5a
Compare
EwanC
commented
Sep 3, 2024
steffenlarsen
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Test using the raw kernel arg objects defined by [sycl_ext_oneapi_raw_kernel_arg](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_raw_kernel_arg.asciidoc) in SYCL-Graphs. Including for parameter update.
6a14f5a
to
8150a8a
Compare
Bensuo
approved these changes
Sep 3, 2024
@intel/llvm-gatekeepers This is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using the
raw_kernel_arg
objects defined by sycl_ext_oneapi_raw_kernel_arg in SYCL-Graphs.The majority of changes in this PR are for supporting the dynamic_parameter feature of SYCL graph. In particular:
The [SYCL] Implement the sycl_oneapi_raw_kernel_arg extension #14335 implementation of
sycl_oneapi_raw_kernel_arg
doesn't use the PIMPL implementation pattern. We therefore add the
dynamic_parameter` impl class as a friend so that, it can access the underlying members.To prevent circular include dependencies we can't include the public facing
raw_kernel_arg.hpp
header in the public facinggraph.hpp
header to using a raw_kernel_arg specific code path fordynamic_parameter
update. Instead we overlead theupdateValue(const void *NewValue, size_t Size);
method withvoid updateValue(const raw_kernel_arg *NewRawValue, size_t Size);
as theraw_kernel_arg
pointer can be forward declared and the compiler will pick the correct code path although theSize
argument is unused.