[SYCL] Add host kernel instantiation for debuggers #15256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in intel#14460 removed the seemingly unused functions for running kernels on on host. However, this turned out to be used by debuggers as they need the kernel code to be in the host executable. This commit adds a simplified version of the kernel instantiation that the aforementioned patch removed. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Timeout in host_task_unsampled_image_write is unrelated. |
|
Ping @bso-intel | @intel/llvm-reviewers-runtime |
| @@ -154,6 +154,8 @@ runKernelWithArg(KernelType KernelName, ArgType Arg) { | |||
| // The pure virtual class aimed to store lambda/functors of any type. | |||
| class HostKernelBase { | |||
| public: | |||
| // NOTE: InstatitateKernelOnHost() should not be called. | |||
| virtual void InstatitateKernelOnHost() = 0; | |||
There was a problem hiding this comment.
Should it be
Suggested change
| virtual void InstatitateKernelOnHost() = 0; | |
| virtual void InstantiateKernelOnHost() = 0; |
?
And also for a comment above
There was a problem hiding this comment.
Addressed in #15300
dm-vodopyanov
approved these changes
Sep 5, 2024
steffenlarsen
added a commit
to steffenlarsen/llvm
that referenced
this pull request
Sep 6, 2024
The changes in intel#15256 unintentionally broke ABI by reordering the virtual member functions of HostKernelBase. This commit amends this by moving the new function to the end of the new member function. Additionally, this fixes a typo in the new function. Signed-off-by: Larsen, Steffen <[email protected]>
againull
pushed a commit
that referenced
this pull request
Sep 6, 2024
The changes in #15256 unintentionally broke ABI by reordering the virtual member functions of HostKernelBase. This commit amends this by moving the new function to the end of the new member function. Additionally, this fixes a typo in the new function. --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Marcos Maronas <[email protected]>
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
The changes in intel#14460 removed the seemingly unused functions for running kernels on on host. However, this turned out to be used by debuggers as they need the kernel code to be in the host executable. This commit adds a simplified version of the kernel instantiation that the aforementioned patch removed. Signed-off-by: Larsen, Steffen <[email protected]>
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
) The changes in intel#15256 unintentionally broke ABI by reordering the virtual member functions of HostKernelBase. This commit amends this by moving the new function to the end of the new member function. Additionally, this fixes a typo in the new function. --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Marcos Maronas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #14460 removed the seemingly unused functions for running kernels on on host. However, this turned out to be used by debuggers as they need the kernel code to be in the host executable.
This commit adds a simplified version of the kernel instantiation that the aforementioned patch removed.