-
Notifications
You must be signed in to change notification settings - Fork 787
[UR][Cuda][Hip] Add support for command-buffer kernel updates #15287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1d31ae
to
bdcd8e2
Compare
e528cb6
to
4e15b9a
Compare
4e15b9a
to
1bdd92a
Compare
1bdd92a
to
cc7c7d5
Compare
2ebc4ac
to
eabd01d
Compare
eabd01d
to
f867e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor question
@intel/llvm-reviewers-runtime there was some tests failing on CI which are now fixed. This PR should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/llvm-gatekeepers This is good to merge thanks |
Please merge this, without this change any update of unified runtime fails to compile with latest intel/llvm due to the breaking abi change. |
Updates the call to urCommandBufferAppendKernelLaunchExp to use the new UR parameters.
Corresponding UR PR: oneapi-src/unified-runtime#1924