Skip to content

[UR][Cuda][Hip] Add support for command-buffer kernel updates #15287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Sep 4, 2024

Updates the call to urCommandBufferAppendKernelLaunchExp to use the new UR parameters.

Corresponding UR PR: oneapi-src/unified-runtime#1924

@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch from c1d31ae to bdcd8e2 Compare September 5, 2024 12:01
@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch 2 times, most recently from e528cb6 to 4e15b9a Compare September 11, 2024 14:34
@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch from 4e15b9a to 1bdd92a Compare September 11, 2024 14:44
@fabiomestre fabiomestre changed the title [UR][Cuda] Add support for command-buffer kernel updates [UR][Cuda][Hip] Add support for command-buffer kernel updates Sep 11, 2024
@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch from 1bdd92a to cc7c7d5 Compare September 11, 2024 15:08
@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch 2 times, most recently from 2ebc4ac to eabd01d Compare September 18, 2024 14:33
@fabiomestre fabiomestre force-pushed the fabio/cmd_buffer_kernel_update branch from eabd01d to f867e71 Compare September 26, 2024 16:44
@aarongreig aarongreig marked this pull request as ready for review September 27, 2024 08:48
@aarongreig aarongreig requested review from a team as code owners September 27, 2024 08:48
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor question

@fabiomestre
Copy link
Contributor Author

fabiomestre commented Sep 30, 2024

@intel/llvm-reviewers-runtime there was some tests failing on CI which are now fixed. This PR should be ready for review.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EwanC
Copy link
Contributor

EwanC commented Oct 1, 2024

@intel/llvm-gatekeepers This is good to merge thanks

@nrspruit
Copy link
Contributor

nrspruit commented Oct 1, 2024

Please merge this, without this change any update of unified runtime fails to compile with latest intel/llvm due to the breaking abi change.

@sarnex sarnex merged commit 48f0e93 into intel:sycl Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants