Skip to content

Add option "-fsycl-allow-device-image-dependencies" #15407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 24, 2024
Merged

Add option "-fsycl-allow-device-image-dependencies" #15407

merged 6 commits into from
Sep 24, 2024

Conversation

LU-JOHN
Copy link
Contributor

@LU-JOHN LU-JOHN commented Sep 16, 2024 •
edited
Loading

Add option "-fsycl-allow-device-image-dependencies". This option replaces "-fsycl-allow-device-dependencies" which is deprecated.

@LU-JOHN LU-JOHN requested review from a team as code owners September 16, 2024 20:46
mdtoguchi
mdtoguchi reviewed Sep 16, 2024
View reviewed changes
mdtoguchi
mdtoguchi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for driver

Lu, John added 6 commits September 17, 2024 08:50
Add -fsycl-allow-device-image-dependencies
68ec6ff 
Signed-off-by: Lu, John <[email protected]>
Fix typo
6cbef0a 
Signed-off-by: Lu, John <[email protected]>
Update option in tests
955012c 
Signed-off-by: Lu, John <[email protected]>
Rename directory
e15d508 
Signed-off-by: Lu, John <[email protected]>
Use BoolOptionWithoutMarshalling
7eeab5b 
Signed-off-by: Lu, John <[email protected]>
Test deprecated options
a62eb80 
Signed-off-by: Lu, John <[email protected]>
asudarsa
asudarsa approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@asudarsa asudarsa merged commit 1d4e066 into intel:sycl Sep 24, 2024
11 checks passed
@aelovikov-intel
Copy link
Contributor 

Failed Tests (3):
SYCL :: DeviceDependencies/free_function_kernels.cpp
SYCL :: LLVMIntrinsicLowering/bitreverse.cpp
SYCL :: LLVMIntrinsicLowering/sub_byte_bitreverse.cpp

seem to be failing in both pre/post-commit after this (https://github.com/intel/llvm/actions/runs/11018616463)

@LU-JOHN , @asudarsa

@aelovikov-intel aelovikov-intel mentioned this pull request Sep 24, 2024
Merged
@Fznamznon Fznamznon mentioned this pull request Sep 25, 2024
Merged
@mdtoguchi mdtoguchi mentioned this pull request Sep 25, 2024
Merged
AlexeySachkov added a commit to AlexeySachkov/llvm that referenced this pull request Sep 25, 2024
@AlexeySachkov
[SYCL][E2E] Fix regression in tests
7747178 
intel#15407 deprecated a flag without updating its uses in tests
which fail due to `-Werror`.
@AlexeySachkov AlexeySachkov mentioned this pull request Sep 25, 2024
Merged
@AlexeySachkov
Copy link
Contributor 

Failed Tests (3):
SYCL :: DeviceDependencies/free_function_kernels.cpp
SYCL :: LLVMIntrinsicLowering/bitreverse.cpp
SYCL :: LLVMIntrinsicLowering/sub_byte_bitreverse.cpp

seem to be failing in both pre/post-commit after this (https://github.com/intel/llvm/actions/runs/11018616463)

@LU-JOHN , @asudarsa

#15511

sarnex pushed a commit that referenced this pull request Sep 25, 2024
@AlexeySachkov
[SYCL][E2E] Fix regression in tests (#15511)
dce9ab3 
#15407 deprecated a flag without updating its uses in tests
which fail due to `-Werror`.
@againull againull mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@asudarsa asudarsa asudarsa approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LU-JOHN @aelovikov-intel @AlexeySachkov @mdtoguchi @asudarsa