-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Remove UR objects release checks on Windows #15425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 1 commit into
intel:sycl
from
omarahmed1111:release-resources-on-windows-shutdown
Oct 7, 2024
Merged
[SYCL] Remove UR objects release checks on Windows #15425
steffenlarsen
merged 1 commit into
intel:sycl
from
omarahmed1111:release-resources-on-windows-shutdown
Oct 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55b2a9b
to
c1050cc
Compare
ccf6a4c
to
bcec694
Compare
bcec694
to
a429332
Compare
a429332
to
96d1736
Compare
96d1736
to
0d1702e
Compare
0d1702e
to
091fea9
Compare
091fea9
to
bd66098
Compare
bd66098
to
955e38d
Compare
955e38d
to
975aca9
Compare
2822cfa
to
c1f4489
Compare
c1f4489
to
0f5894c
Compare
0f5894c
to
63a28ff
Compare
maarquitos14
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, otherwise LGTM.
63a28ff
to
b91d5b9
Compare
Please, don't force-push after reviews started, as it makes it difficult for reviewers to know what changes are new and what changes are already reviewed. |
@intel/llvm-gatekeepers Please merge, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These e2e tests started failing after PI removal and replacing it with UR (PR) However, they were not related to it.
On Windows, dlls unloading is inconsistent and if we try to release these UR objects manually, inconsistent hangs happen due to a race between unloading the UR adapters dlls (in addition to their dependency dlls) and the releasing of these UR objects (The proxy loader have solved this problem partially here). So, we currently shutdown without releasing them and windows should handle the memory cleanup.
This behaviour is the same old behaviour as before removing PI as on Investigations on this. This was only hidden before PI removal as it was calling the PI entry-point but doesn't make it to UR entry-point and Filecheck logs check for objects release would pass as it only check for the call to the PI entry-point without check that the call was a successful call. That was the PI call for
piContextRelease
before PI removal:Fixes #14768
Fixes #14950
Fixes #14968