-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][E2E] fixed UR FileCheck conditions to match new traces #15439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad1b9f1
to
15faf1a
Compare
653c968
to
d3d5ed2
Compare
d3d5ed2
to
a9863d6
Compare
a9863d6
to
ad6ee70
Compare
ad6ee70
to
4ff661f
Compare
4ff661f
to
b1e320d
Compare
b1e320d
to
685e53a
Compare
e32ac5c
to
0ee3e17
Compare
0ee3e17
to
a46743e
Compare
a46743e
to
0180aa7
Compare
uditagarwal97
approved these changes
Oct 2, 2024
) makes llvm work with this change: oneapi-src/unified-runtime#2101 fixes this bug: oneapi-src/unified-runtime#2002
…#15439) Revert "[SYCL][E2E] Bypass L0 adapter tracing in grf tests (intel#15167)" because oneapi-src/unified-runtime#2002 is fixed This reverts commit 3e00e38.
4bb60a4
to
a7290a9
Compare
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with ugly interleaved Level0 adapter and Level0 Unified Runtime traces, that is oneapi-src/unified-runtime#2002 issue, has been fixed in oneapi-src/unified-runtime#2101.
This PR adds necessary changes to e2e tests to make them pass with modified tracing in L0 Adapter.
This PR also reverts #15167 which disabled some traces because of the bug which is now fixed, so traces can be restored.