[SYCL][Docs] Allow discarded events case for ext_oneapi_get_last_event #15638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior for queue::ext_oneapi_get_last_event when the queue either does not currently have a last event or the last event was discarded. In these cases, the implementation will now insert a marker event at the end of the queue which signifies the work related to the last command in the queue. Additionally, this allows us to relax the requirements for the extension to now allow it to be used on queues where discarding of events is enabled. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Oct 9, 2024
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dm-vodopyanov
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior for queue::ext_oneapi_get_last_event when the queue either does not currently have a last event or the last event was discarded. In these cases, the implementation will now insert a marker event at the end of the queue which signifies the work related to the last command in the queue.
Additionally, this allows us to relax the requirements for the extension to now allow it to be used on queues where discarding of events is enabled.