[SYCL] Add property validation for kernel_bundle free functions and graph extension

[KseniyaTikhomirova]

extra changes, follow up for #15253

[EwanC]

Is there SYCL spec language that specifies that exception can/may/must be thrown for invalid properties? Not sure if there's something in the SYCL-Graph extension spec that would need updated to reflect this behavior.

[uditagarwal97]

Suggested change

	}
	}

[KseniyaTikhomirova]

fixed in 808287a

[uditagarwal97]

Suggested change

	// no supported properties now
	// unsupported property.

Or something like that.

[KseniyaTikhomirova]

fixed in 808287a

[KseniyaTikhomirova]

Is there SYCL spec language that specifies that exception can/may/must be thrown for invalid properties? Not sure if there's something in the SYCL-Graph extension spec that would need updated to reflect this behavior.

spec is not yet updated but there is a question mostly if we should make exception required officially:
"In both cases, it would be valid for the implementation to throw an exception from the constructor if the property list contains incompatible properties. Therefore, the only difference is whether the exception is mandated."

KhronosGroup/SYCL-Docs#643

in any case I think it would be a general rule that doesn't require update of extension spec.

[EwanC]

spec is not yet updated but there is a question mostly if we should make exception required officially:
"In both cases, it would be valid for the implementation to throw an exception from the constructor if the property list contains incompatible properties. Therefore, the only difference is whether the exception is mandated."

https://github.com/KhronosGroup/SYCL-Docs/issues/643

in any case I think it would be a general rule that doesn't require update of extension spec.

Thanks for following up on that with the SYCL-WG, I don't think waiting on an outcome needs to block this PR.

I have a couple of minor review comments.

[KseniyaTikhomirova]

@uditagarwal97 kindly ping

[uditagarwal97]

SYCL Changes LGTM.

[KseniyaTikhomirova]

Hello @intel/llvm-gatekeepers, this PR is ready to be merged. Thanks!

[steffenlarsen]

@KseniyaTikhomirova - The test results are 3 weeks old. Would you mind pushing a merge commit first? Feel free to ping me directly once it's green.