[SYCL] Add missing special values to exp(complex) #15672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
exp(x,NaN) (for any finite x) = (NaN,NaN) exp(NaN,y) (for any nonzero y) = (NaN,NaN) exp(x,+∞) (for any finite x) = (NaN,NaN) https://en.cppreference.com/w/cpp/numeric/complex/exp E2E: intel#15666
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime could you take a look please? |
steffenlarsen
approved these changes
Oct 15, 2024
Comment on lines
+157
to
+158
| } else if (__spirv_IsFinite(z_real)) { | ||
| if (__spirv_IsNan(z_imag) || __spirv_IsInf(z_imag)) |
There was a problem hiding this comment.
Nit:
Suggested change
| } else if (__spirv_IsFinite(z_real)) { | |
| if (__spirv_IsNan(z_imag) || __spirv_IsInf(z_imag)) | |
| } else if (__spirv_IsFinite(z_real) && | |
| (__spirv_IsNan(z_imag) || __spirv_IsInf(z_imag))) { |
KornevNikita
added a commit
to KornevNikita/llvm
that referenced
this pull request
Nov 4, 2024
Follow-up to intel#15672 This patch updates float behavior
sarnex
pushed a commit
that referenced
this pull request
Nov 7, 2024
Follow-up to #15672 This patch updates float behavior --------- Signed-off-by: jinge90 <[email protected]> Co-authored-by: jinge90 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exp(x,NaN) (for any finite x) = (NaN,NaN)
exp(NaN,y) (for any nonzero y) = (NaN,NaN)
exp(x,+∞) (for any finite x) = (NaN,NaN)
https://en.cppreference.com/w/cpp/numeric/complex/exp
E2E: #15666