Skip to content

info::device::atomic64 is deprecated #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 12, 2024
Merged

info::device::atomic64 is deprecated #15740

merged 8 commits into from
Nov 12, 2024

Conversation

dklochkov-emb
Copy link
Contributor

  1. A separate .def file was created for deprecated features that are not part of SYCL 2020 spec
  2. info::device::atomic64 was deprecated
  3. Test for info::device::atomic64 deprecated was added into separate file due to -Wno-deprecated-declarations flag in warnings.cpp tests file.

@dklochkov-emb dklochkov-emb requested a review from a team as a code owner October 17, 2024 12:45
AlexeySachkov
AlexeySachkov reviewed Oct 17, 2024
View reviewed changes
@KornevNikita
Copy link
Contributor

KornevNikita commented Oct 17, 2024 •
edited
Loading

Test for info::device::atomic64 deprecated was added into separate file due to -Wno-deprecated-declarations flag in warnings.cpp tests file.

Just curious - did you try warnings.cpp actually? Not sure, but I think I tried it sometime ago and there was no need for a separate test.

UPD. I've likely tried another test - test/warnings/sycl_2020_deprecations.cpp. You can try updating it instead of creating a separate one.
I'd also suggest to update our code, so we don't use this deprecated query.

@AlexeySachkov
Copy link
Contributor

Just curious - did you try warnings.cpp actually? Not sure, but I think I tried it sometime ago and there was no need for a separate test.

warnings.cpp is focused on sycl.hpp being warning-free on its own, it is not for checking that right diagnostics are emitted

UPD. I've likely tried another test - test/warnings/sycl_2020_deprecations.cpp. You can try updating it instead of creating a separate one.

That is not a SYCL 2020 deprecation, that deprecation does not depend on the language version, so I think that a separate test is better.

I'd also suggest to update our code, so we don't use this deprecated query.

That's a good point! warnings.cpp should be updated to fail unless this is fixed to ensure that we also cover this use case. I suppose that not all code paths may produce warnings, simply because we don't instantiate those templates in the test.

@dklochkov-emb dklochkov-emb force-pushed the sycl-deprecate-info-device-atomic64 branch from cb4b523 to f4f00f4 Compare October 18, 2024 09:18
@dklochkov-emb
[SYCL]: info::device::atomic64 is deprecated
cddf3f9 
[SYCL]: move extension related deprecation to the old file

[SYCL]: fix check-sycl tests

[SYCL]: fix file ending
@dklochkov-emb dklochkov-emb force-pushed the sycl-deprecate-info-device-atomic64 branch from f4f00f4 to cddf3f9 Compare October 18, 2024 09:25
@AlexeySachkov
Copy link
Contributor

I'd also suggest to update our code, so we don't use this deprecated query.

That's a good point! warnings.cpp should be updated to fail unless this is fixed to ensure that we also cover this use case. I suppose that not all code paths may produce warnings, simply because we don't instantiate those templates in the test.

I've realized the the call we perform happens within the library, so it doesn't affect public headers and can't be checked by warnings.cpp. I agree with Nikita that we should address it (most likely our -Werror build in post-commit will fail otherwise), but please disregard the comment about updating warnings.cpp

@dklochkov-emb dklochkov-emb requested a review from a team as a code owner October 18, 2024 12:46
@AlexeySachkov
Copy link
Contributor

@cperkinsintel, @intel/llvm-reviewers-runtime, could you please take a look?

aelovikov-intel
aelovikov-intel reviewed Oct 23, 2024
View reviewed changes
aelovikov-intel
aelovikov-intel reviewed Nov 4, 2024
View reviewed changes
sycl/test-e2e/Config/kernel_from_file.cpp Outdated
@@ -14,7 +14,7 @@
// RUN: %if linux %{ llvm-link -o=%t_app.bc %t.bc %t_compiler_wrappers.bc %t_sanitizer.bc %} %else %{ llvm-link -o=%t_app.bc %t.bc %t_compiler_wrappers.bc %}
// >> ---- translate to SPIR-V
// RUN: llvm-spirv -o %t.spv %t_app.bc
// RUN: %clangxx -Wno-error=ignored-attributes -DSYCL_DISABLE_FALLBACK_ASSERT %cxx_std_optionc++17 %include_option %t.h %s -o %t.out %sycl_options -fno-sycl-dead-args-optimization -Xclang -verify-ignore-unexpected=note,warning
// RUN: %clangxx -Wno-error=ignored-attributes -Wno-error=deprecated-declarations -DSYCL_DISABLE_FALLBACK_ASSERT %cxx_std_optionc++17 %include_option %t.h %s -o %t.out %sycl_options -fno-sycl-dead-args-optimization -Xclang -verify-ignore-unexpected=note,warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we change %include_option to -isystem as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aelovikov-intel aelovikov-intel merged commit 643d4ff into intel:sycl Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dklochkov-emb @KornevNikita @AlexeySachkov @aelovikov-intel