Skip to content

[DeviceASAN] Move GlobalShadowOffset, DeviceType, Debug into LaunchInfo #15773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Oct 21, 2024

@pbalcer
Copy link
Contributor

pbalcer commented Oct 22, 2024

@zhaomaosu please update the PR to point to the merged commit.

@zhaomaosu zhaomaosu marked this pull request as ready for review October 22, 2024 09:08
@zhaomaosu zhaomaosu requested review from a team as code owners October 22, 2024 09:08
@zhaomaosu
Copy link
Contributor Author

@zhaomaosu please update the PR to point to the merged commit.

Thanks, updated.

@againull
Copy link
Contributor

againull commented Oct 22, 2024

@intel/dpcpp-sanitizers-review Could you please provide a review.

@againull
Copy link
Contributor

Failures:
SYCL :: AOT/double.cpp
SYCL :: AOT/half.cpp
SYCL :: AOT/reqd-sg-size.cpp
are unrelated and going to be fixed by #15823

@againull againull merged commit 98a5357 into intel:sycl Oct 23, 2024
11 of 12 checks passed
@sarnex
Copy link
Contributor

sarnex commented Oct 23, 2024

@zhaomaosu @intel/dpcpp-sanitizers-review Seeing many postcommit fails on Arc:

 Failed Tests (26):
  SYCL :: AddressSanitizer/common/demangle-kernel-name.cpp
  SYCL :: AddressSanitizer/common/option-redzone-size.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-int.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-long.cpp
  SYCL :: AddressSanitizer/misaligned/misalign-short.cpp
  SYCL :: AddressSanitizer/multiple-reports/multiple_kernels.cpp
  SYCL :: AddressSanitizer/multiple-reports/one_kernel.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/device_global_image_scope_unaligned.cpp
  SYCL :: AddressSanitizer/out-of-bounds/DeviceGlobal/multi_device_images.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/large_group_size.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_char.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_func.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_int.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_for_short.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/parallel_no_local_size.cpp
  SYCL :: AddressSanitizer/out-of-bounds/USM/unaligned_shadow_memory.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_2d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_3d.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/buffer_copy_fill.cpp
  SYCL :: AddressSanitizer/out-of-bounds/buffer/subbuffer.cpp
  SYCL :: AddressSanitizer/use-after-free/quarantine-no-free.cpp
  SYCL :: AddressSanitizer/use-after-free/use-after-free.cpp

https://github.com/intel/llvm/actions/runs/11474026543/job/31930862668

If we can't fix ASAP, can we please revert this? Thanks

@zhaomaosu
Copy link
Contributor Author

Hi @sarnex, I'll take a look and see if I can provide a quick fix. Thanks.

@zhaomaosu
Copy link
Contributor Author

Opened a PR to temporarily disable device sanitizer tests until the post-commit failures have been fixed #15825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants