Skip to content

[SYCL][E2E] Update some XFAIL tests #15908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/accessor/accessor.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out
// RUN: %{run} %t.out

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826

//==----------------accessor.cpp - SYCL accessor basic test ----------------==//
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// https://github.com/intel/llvm/issues/13887
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/13887
// If users need to use host pipe feature provided by experimental::pipe, all
// pipes in their design should use the experimental::pipe (as a workround).

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Basic/image/srgba-read.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// REQUIRES: aspect-ext_oneapi_srgb, aspect-ext_intel_legacy_image
// https://github.com/intel/llvm/issues/14387
// XFAIL: gpu-intel-dg2
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14387
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out | FileCheck %s

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: opencl, opencl_icd

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826

// RUN: %{build} -D__SYCL_INTERNAL_API -o %t.out %opencl_lib -O3
// RUN: %{run} %t.out
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// REQUIRES: arch-intel_gpu_pvc, ocloc

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826

// RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out
// RUN: %{run} %t.out
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/ESIMD/assert.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
//
// The test still fails after GPU driver update on Linux. Temporary marking it
// as expected to fail, whilst it is being investigated, see intel/llvm#11359
// FIXME: remove that XFAIL
// XFAIL: linux
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11359
//
// Hanging on gen12, remove when internal tracker fixed
// UNSUPPORTED: gpu-intel-gen12
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@

// UNSUPPORTED: hip || cuda

// TODO: Remove XFAIL after fixing
// https://github.com/intel/intel-graphics-compiler/issues/330
// XFAIL: gpu
// XFAIL-TRACKER: https://github.com/intel/intel-graphics-compiler/issues/330

// Make dump directory.
// RUN: rm -rf %t.spvdir && mkdir %t.spvdir
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/Plugin/interop-cuda-experimental.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// RUN: %{build} %cuda_options -o %t.out
// RUN: %{run} %t.out

// An issue has been reported in https://github.com/intel/llvm/issues/14116
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14116

#define SYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL 1
#include <sycl/backend.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// RUN: %{build} %cuda_options -lcudart -lcuda -x cuda -o %t.out
// RUN: %{run} %t.out

// An issue has been reported in https://github.com/intel/llvm/issues/14115
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14116

#include <cuda.h>
#include <sycl/detail/core.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
// VTables are global variables with possibly external linkage and that causes
// them to be copied into every module we produce during device code split
// which in turn leads to multiple definitions error at runtime.
// https://github.com/intel/llvm/issues/15069
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15069
//
// This test covers a scenario where virtual functions defintion and their uses
// are split into different translation units. In particular:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
// function definitions and therefore we won't mark construct kernel as using
// virtual functions and link operation at runtime will fail due to undefined
// references to virtual functions from vtable.
// https://github.com/intel/llvm/issues/15071
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15071
//
// This test covers a scenario where virtual functions defintion and their uses
// are all split into different translation units.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
// function definitions and therefore we won't mark construct kernel as using
// virtual functions and link operation at runtime will fail due to undefined
// references to virtual functions from vtable.
// https://github.com/intel/llvm/issues/15071
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15071
//
// This test covers a scenario where virtual functions defintion and their uses
// are split into different translation units. In particular:
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/lit.cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
config.name = "SYCL"

# suffixes: A list of file extensions to treat as test files.
config.suffixes = [".c", ".cpp"]
config.suffixes = [".cpp"]

config.excludes = ["Inputs"]

Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
* launch<F> with policy & use local memory tests
**************************************************************************/

// https://github.com/intel/llvm/issues/14826
// XFAIL: arch-intel_gpu_pvc
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14826

// RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out
// RUN: %{run} %t.out
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// - ...and check if the list of improperly UNSUPPORTED tests needs to be updated.
//
// RUN: grep -rI "UNSUPPORTED:" %S/../../test-e2e \
// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
// RUN: -A 1 --include=*.cpp --no-group-separator | \
// RUN: grep -v "UNSUPPORTED:" | \
// RUN: grep -Pv "UNSUPPORTED-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)|(?:UNSUPPORTED-INTENDED:\s*.+)" > %t
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-UNSUPPORTED-WITHOUT-INFO
Expand Down
17 changes: 2 additions & 15 deletions sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
// - ...and check if the list of improperly XFAIL-ed tests needs to be updated.
//
// RUN: grep -rI "XFAIL:" %S/../../test-e2e \
// RUN: -A 1 --include=*.c --include=*.cpp --no-group-separator | \
// RUN: -A 1 --include=*.cpp --no-group-separator | \
// RUN: grep -v "XFAIL:" | \
// RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" > %t
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
Expand All @@ -51,20 +51,17 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 156
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 143
//
// List of improperly XFAIL-ed tests.
// Remove the CHECK once the test has been propely XFAIL-ed.
//
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
// CHECK-NEXT: Basic/accessor/accessor.cpp
// CHECK-NEXT: Basic/aspects.cpp
// CHECK-NEXT: Basic/buffer/reinterpret.cpp
// CHECK-NEXT: Basic/built-ins.cpp
// CHECK-NEXT: Basic/device_event.cpp
// CHECK-NEXT: Basic/diagnostics/handler.cpp
// CHECK-NEXT: Basic/fpga_tests/fpga_pipes_mixed_usage.cpp
// CHECK-NEXT: Basic/image/srgba-read.cpp
// CHECK-NEXT: Basic/max_linear_work_group_size_props.cpp
// CHECK-NEXT: Basic/max_work_group_size_props.cpp
// CHECK-NEXT: Basic/partition_supported.cpp
Expand All @@ -73,12 +70,9 @@
// CHECK-NEXT: Basic/span.cpp
// CHECK-NEXT: Basic/stream/auto_flush.cpp
// CHECK-NEXT: DeprecatedFeatures/queue_old_interop.cpp
// CHECK-NEXT: DeprecatedFeatures/set_arg_interop.cpp
// CHECK-NEXT: DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp
// CHECK-NEXT: DeviceCodeSplit/split-per-kernel.cpp
// CHECK-NEXT: DeviceCodeSplit/split-per-source-main.cpp
// CHECK-NEXT: DeviceLib/assert-windows.cpp
// CHECK-NEXT: ESIMD/assert.cpp
// CHECK-NEXT: ESIMD/hardware_dispatch.cpp
// CHECK-NEXT: GroupAlgorithm/root_group.cpp
// CHECK-NEXT: GroupLocalMemory/group_local_memory.cpp
Expand All @@ -93,7 +87,6 @@
// CHECK-NEXT: InvokeSimd/Spec/tuple_return.cpp
// CHECK-NEXT: InvokeSimd/Spec/tuple_vadd.cpp
// CHECK-NEXT: KernelAndProgram/kernel-bundle-merge-options.cpp
// CHECK-NEXT: LLVMIntrinsicLowering/sub_byte_bitreverse.cpp
// CHECK-NEXT: Matrix/SG32/joint_matrix_annotated_ptr.cpp
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_colmajorA_colmajorB.cpp
// CHECK-NEXT: Matrix/SG32/joint_matrix_bfloat16_packedB.cpp
Expand Down Expand Up @@ -177,8 +170,6 @@
// CHECK-NEXT: NewOffloadDriver/sycl-external-with-optional-features.cpp
// CHECK-NEXT: OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp
// CHECK-NEXT: PerformanceTests/Reduction/reduce_over_sub_group.cpp
// CHECK-NEXT: Plugin/interop-cuda-experimental.cpp
// CHECK-NEXT: Plugin/interop-experimental-single-TU-SYCL-CUDA-compilation.cpp
// CHECK-NEXT: Printf/int.cpp
// CHECK-NEXT: Printf/mixed-address-space.cpp
// CHECK-NEXT: Printf/percent-symbol.cpp
Expand Down Expand Up @@ -208,7 +199,3 @@
// CHECK-NEXT: Scheduler/MultipleDevices.cpp
// CHECK-NEXT: Scheduler/ReleaseResourcesTest.cpp
// CHECK-NEXT: Tracing/buffer_printers.cpp
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-call.cpp
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-vf-defs-and-call.cpp
// CHECK-NEXT: VirtualFunctions/multiple-translation-units/separate-vf-defs.cpp
// CHECK-NEXT: syclcompat/launch/launch_policy_lmem.cpp
Loading