[libclc] Split off library build system into helpers #15914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
Thank you @frasercrmck for preemptive fix! |
This splits off several key parts of the build system into utility methods. This will be used in upcoming patches to help provide additional sets of target-specific builtin libraries. Running llvm-diff on the resulting LLVM bytecode binaries, and regular diff on SPIR-V binaries, shows no differences before and after this patch.
frasercrmck
force-pushed
the
cherry-pick-libclc-1
branch
from
0fe7326 to
94d928c
Compare
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
added a commit
that referenced
this pull request
Oct 29, 2024
maarquitos14
added a commit
that referenced
this pull request
Oct 29, 2024
maarquitos14
added a commit
that referenced
this pull request
Oct 29, 2024
|
@intel/llvm-gatekeepers This is ready to merge, thanks. I've got one more to cherry-pick after this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits off several key parts of the build system into utility methods. This will be used in upcoming patches to help provide additional sets of target-specific builtin libraries.
Running llvm-diff on the resulting LLVM bytecode binaries, and regular diff on SPIR-V binaries, shows no differences before and after this patch.
This is a cherry-pick of upstream commit 183b38e. The conflicts weren't trivial so I thought I'd resolve them myself and not wait for a pulldown. CC @jsji