[SYCL] Enable E2E test of fp64 conversion emulation #15923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| nfail += test<long>(q); | ||
| nfail += test<float>(q); | ||
| if (q.get_device().has(aspect::fp64)) | ||
| nfail += test<double>(q); |
There was a problem hiding this comment.
Let's also have test_conv or something, which would use a different op. Right now the op you have performs an operation directly on T. The new op should do static_cast<int>(x) + 1. test_conv<double> should be launched regardless of double support on a device and it should always work. For simplicity, op could be made a template argument of test, I guess.
AlexeySachkov
approved these changes
Nov 21, 2024
dm-vodopyanov
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.