[SYCL][NATIVECPU] Implement events on Native CPU #15926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
approved these changes
Nov 5, 2024
|
|
||
| std::vector<bool> res; | ||
| res.push_back(test<int>(q)); | ||
| res.push_back(test<unsigned>(q)); |
There was a problem hiding this comment.
Performance. Using a vector here likely causes allocations and there's the overhead of iterating over the vector.
It's probably faster to instead check the test values and return straight away if there's an error.
| const T test{42}; | ||
|
|
||
| myQueue.submit([&](handler &cgh) { | ||
| auto A = a.template get_access<access::mode::write>(cgh); |
There was a problem hiding this comment.
It might be worth replicating this test also for access::mode::read_write to see if timing/events handling is correct for different access modes.
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Nov 13, 2024
|
@intel/llvm-gatekeepers this looks ready to merge, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing PR for oneapi-src/unified-runtime#2254