[SYCL] Add support for free function kernel builtins #15938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Support for the following three builtins are added: __builtin_sycl_is_single_task_kernel(function-pointer) __builtin_sycl_is_nd_range_kernel(function-pointer, dimension) __builtin_sycl_is_kernel(function-pointer) __builtin_sycl_is_single_task_kernel returns true if the function pointer represents a function with the IR attribute "sycl-single-task-kernel". __builtin_sycl_is_nd_range_kernel returns true if the function pointer represents a function with the IR attribute "sycl-single-task-kernel" with a matching dimension. __builtin_sycl_is_kernel returns true if the function pointer represents a function with either of the two IR attributes.
premanandrao
force-pushed
the
remote_bltns
branch
from
5add9a9 to
e4face5
Compare
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| .getZExtValue(); | ||
| // Return true only if the dimensions match. | ||
| if (std::stoul(NVPair.second) == Dim) | ||
| return RValue::get( |
There was a problem hiding this comment.
Can you explain what passing the type to the getTrue( ) API does here? Is it possible to just return 0 or 1 if you are converting to ConstantInt anyway?
There was a problem hiding this comment.
I am not that familiar with this - but passing the type makes the function return a true value in the context of the type. There is another interface for getTrue, but it takes the LLVM context as its argument and returns a true value in that context. Passing the type made more sense and that is what other builtins seem to do too.
There was a problem hiding this comment.
Thank you for explaining
elizabethandrews
approved these changes
Nov 18, 2024
smanna12
approved these changes
Nov 19, 2024
|
@intel/llvm-gatekeepers, this PR may be merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the following three builtins are added: __builtin_sycl_is_single_task_kernel(function-pointer) __builtin_sycl_is_nd_range_kernel(function-pointer, dimension) __builtin_sycl_is_kernel(function-pointer)
__builtin_sycl_is_single_task_kernel returns true if the function pointer represents a function with the IR attribute "sycl-single-task-kernel".
__builtin_sycl_is_nd_range_kernel returns true if the function pointer represents a function with the IR attribute "sycl-single-task-kernel" with a matching dimension.
__builtin_sycl_is_kernel returns true if the function pointer represents a function with either of the two IR attributes.