[SYCL][Doc] Add extension mechanism proposal #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First public review for SYCL extension mechanism proposal. Signed-off-by: Greg Lueck <[email protected]>
bader
added
the
spec extension
jbrodman
approved these changes
May 7, 2020
Comment on lines
+180
to
+183
| above. Thus, the attribute namespace `sycl` is reserved for {cpp} attributes | ||
| used in the core SYCL specification, `sycl::khr` is reserved for Khronos | ||
| ratified extensions, and `sycl::ext::<vendorname>` is reserved for vendor | ||
| extensions. |
There was a problem hiding this comment.
Good point. This part of the spec should be rewritten as follows:
Extensions may also add C++ attributes. The attribute namespace
sycl::is reserved for attributes in the core SYCL specification and for Khronos ratified extensions. Vendor defined extensions should use a different attribute namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First public review for SYCL extension mechanism proposal.
Signed-off-by: Greg Lueck [email protected]