Skip to content

Update the kernel_queue_specific::max_num_work_group query #16051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 6, 2024

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Nov 12, 2024

Update calls to urKernelSuggestMaxCooperativeGroupCountExp to match the changes in oneapi-src/unified-runtime#2316. This PR also implements the range<1> and range<2> overloads of the ext_oneapi_get_info API from sycl_ext_oneapi_launch_queries.

Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
@0x12CC
Copy link
Contributor Author

0x12CC commented Nov 27, 2024

@intel/llvm-reviewers-runtime, could you please review this PR? It's done but I have it marked as draft so that the changes to the UR CMake files don't get merged. I'll revert the change in FetchUnifiedRuntime.cmake and update the UR tag once oneapi-src/unified-runtime#2316 is merged.

@0x12CC
Copy link
Contributor Author

0x12CC commented Nov 28, 2024

@uditagarwal97, thanks for the review. Could you please approve this PR or request any changes you need me to make? We won't be able to merge oneapi-src/unified-runtime#2316 until this PR is approved.

@0x12CC 0x12CC marked this pull request as ready for review November 28, 2024 15:10
@0x12CC 0x12CC requested review from a team as code owners November 28, 2024 15:10
@0x12CC 0x12CC requested a review from againull November 28, 2024 15:10
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Michael Aziz <[email protected]>
@martygrant martygrant merged commit 336b89e into intel:sycl Dec 6, 2024
13 checks passed
@0x12CC 0x12CC deleted the root_group_query branch December 6, 2024 14:05
KornevNikita pushed a commit that referenced this pull request Feb 25, 2025
Update calls to `urKernelSuggestMaxCooperativeGroupCountExp` to match
the changes in oneapi-src/unified-runtime#2316.
This PR also implements the `range<1>` and `range<2>` overloads of the
`ext_oneapi_get_info` API from
[sycl_ext_oneapi_launch_queries](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_launch_queries.asciidoc).

---------

Signed-off-by: Michael Aziz <[email protected]>
Co-authored-by: Martin Morrison-Grant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants