[CI] Fix AMDGPU arch flag for Codeplay runner #16053
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
|
Cancelled the CI here to not waste resources |
| @@ -284,7 +284,11 @@ jobs: | |||
| echo "opts=$CMAKE_EXTRA_ARGS" >> $GITHUB_OUTPUT | |||
| else | |||
| if [ "${{ contains(inputs.target_devices, 'ext_oneapi_hip') }}" == "true" ]; then | |||
| echo 'opts=-DHIP_PLATFORM="AMD" -DAMD_ARCH="gfx1031"' >> $GITHUB_OUTPUT | |||
| if [ "${{ runner.name }}" == "cp-amd-runner" ]; then | |||
There was a problem hiding this comment.
I'm a bit hesitant about hard coding the runner name here. Just like we have extra_lit_opts, can we have another matrix input, something like extra_lit_build_opts, for passing runner specific build options? Or perhaps we can reuse inputs.extra_cmake_args?
There was a problem hiding this comment.
we could, but wouldn't we have to have the same hardcoded runner name check at the place where we decide what to pass for extra_lit_opts? There are two runners and they need different values for this variable. I think the real solution is running sycl-ls and grepping the output for the architecture, but I didn't want to overengineer it if the solution in this PR is acceptable.
There was a problem hiding this comment.
True, running sycl-ls and grepping the architecture type would be an ideal solution. I don't have strong objection to the changes in this PR, so I'll approve, but can you also create a Github issue to "use sycl-ls for determining the runner architecture type"? I can implement that once I get some free cycles.
There was a problem hiding this comment.
sure, i can own it actually, seems at least somewhat interesting.
New HIP runner is up and running but it's a different card so we need a different arch flag.
Not the cleanest solution but this isn't really going to scale.
Confirmed working here.