Skip to content

[SYCL][NFC] Fix ctad warnings #16054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[SYCL][NFC] Fix ctad warnings #16054

merged 3 commits into from
Nov 13, 2024

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Nov 12, 2024

llvm/sycl/source/detail/context_impl.cpp:496:48: error: 'std::set' may
not intend to support class template argument deduction
[-Werror,-Wctad-maybe-unsupported]

llvm/sycl/source/detail/context_impl.cpp:496:48: error: 'std::set' may
not intend to support class template argument deduction
[-Werror,-Wctad-maybe-unsupported]
@jsji jsji requested a review from a team as a code owner November 12, 2024 17:19
@jsji jsji requested a review from steffenlarsen November 12, 2024 17:19
@bader bader changed the title [NFC] Fix ctad warnings [SYCL][NFC] Fix ctad warnings Nov 12, 2024
@jsji jsji self-assigned this Nov 13, 2024
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 8a5d80f into sycl Nov 13, 2024
13 checks passed
@bader bader deleted the ctadfix2 branch December 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants