[SYCL] Don't use boost/mp11 for properties filtering #16076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
properties-filtering
branch
from
2a01067 to
03d7051
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Nov 14, 2024
| std::array<int, N> indexes{}; | ||
| int num_matched = 0; | ||
| int idx = 0; | ||
| (((predicate<property_tys>::value ? indexes[num_matched++] = idx++ : idx++), |
There was a problem hiding this comment.
For the sake of mental association, I would add another set of parenthesis:
Suggested change
| (((predicate<property_tys>::value ? indexes[num_matched++] = idx++ : idx++), | |
| (((predicate<property_tys>::value ? (indexes[num_matched++] = idx++) : idx++), |
There was a problem hiding this comment.
I'll make a note of that and will implement in a separate PR with final touches after major refactorings are all finished.
| const properties<properties_type_list<property_tys...>> &props) { | ||
| return filter_properties_impl<predicate, property_tys...>::apply(props); | ||
| } | ||
|
|
There was a problem hiding this comment.
The naming scheme used in this patch does not seem to follow the surrounding code.
There was a problem hiding this comment.
Discussed offline - I'm following the style in properties.hpp because I'll be moving this new code into a single source and removing the surrounding code in near future. Also, we're already very inconsistent in different places with properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to get rid of it for the upstreaming purposes.