Skip to content

[NFC][SYCL] Update comments in sycl/test/abi/sycl_abi_neutrality_test.cpp #16192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

[NFC][SYCL] Update comments in sycl/test/abi/sycl_abi_neutrality_test.cpp #16192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions sycl/test/abi/sycl_abi_neutrality_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,27 @@
// issue and have to use their ABI-neutral counterparts provided by SYCL RT (e.g
// sycl::detail::string, etc.).

// New exclusions are NOT ALLOWED to this file. All remaining cases that need
// to be fixed are listed below.
// New exclusions are NOT ALLOWED to this file. Some entry points were not fixed
// in time during the last ABI breaking window, so we have to keep providing the
// entry points for them even if newer version of the headers stops using those
// old entry points. Others were exported unnecessarily but only actually used
// inside DSO, yet we have to keep the entry points as well.

// https://github.com/intel/llvm/pull/16179
// CHECK:_ZN4sycl3_V13ext5intel12experimental15online_compilerILNS3_15source_languageE0EE7compileIJSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaISE_EEEEES8_IhSaIhEERKSE_DpRKT_
// CHECK:_ZN4sycl3_V13ext5intel12experimental15online_compilerILNS3_15source_languageE1EE7compileIJSt6vectorINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESaISE_EEEEES8_IhSaIhEERKSE_DpRKT_
//
// https://github.com/intel/llvm/pull/16178
// CHECK:_ZN4sycl3_V13ext5intel12experimental9pipe_base13get_pipe_nameB5cxx11EPKv
//
// https://github.com/intel/llvm/pull/16177
// CHECK:_ZN4sycl3_V16detail6OSUtil10getDirNameB5cxx11EPKc
// CHECK:_ZN4sycl3_V16detail6OSUtil16getCurrentDSODirB5cxx11Ev
//
// https://github.com/intel/llvm/pull/16176
// CHECK:_ZN4sycl3_V16opencl13has_extensionERKNS0_6deviceERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
// CHECK:_ZN4sycl3_V16opencl13has_extensionERKNS0_8platformERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
//
// https://github.com/intel/llvm/pull/15694 and
// https://github.com/intel/llvm/pull/16194
// CHECK:_ZNK4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph11print_graphENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb
Loading