Skip to content

[SYCL] Don't emit @__cxa_pure_virtual into device code #16231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clang/lib/CodeGen/CGVTables.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,12 @@ void CodeGenVTables::addVTableComponent(ConstantArrayBuilder &builder,
}

auto getSpecialVirtualFn = [&](StringRef name) -> llvm::Constant * {
// There is no guarantee that special function for handling pure virtual
// calls will be provided by a SYCL backend compiler and therefore we
// simply emit nullptr here.
if (CGM.getLangOpts().SYCLIsDevice)
return llvm::ConstantPointerNull::get(CGM.GlobalsInt8PtrTy);

// FIXME(PR43094): When merging comdat groups, lld can select a local
// symbol as the signature symbol even though it cannot be accessed
// outside that symbol's TU. The relative vtables ABI would make
Expand Down
40 changes: 40 additions & 0 deletions clang/test/CodeGenSYCL/dont-emit-cxx-pure-virtual.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// There is no guarantee that special symbol @__cxa_pure_virtual is supported
// by SYCL backend compiler, so we need to make sure that we don't emit it
// during SYCL device compilation.
//
// RUN: %clang_cc1 -triple spir64 -fsycl-is-device -emit-llvm %s -o - | FileCheck %s
//
// CHECK-NOT: @__cxa_pure_virtual

SYCL_EXTERNAL bool rand();

class Base {
public:
[[__sycl_detail__::add_ir_attributes_function("indirectly-callable", "a")]]
virtual void display() {}

virtual void pure_host() = 0;

[[__sycl_detail__::add_ir_attributes_function("indirectly-callable", "a")]]
virtual void pure_device() = 0;
};

class Derived1 : public Base {
public:
[[__sycl_detail__::add_ir_attributes_function("indirectly-callable", "a")]]
void display() override {}

void pure_host() override {}

[[__sycl_detail__::add_ir_attributes_function("indirectly-callable", "a")]]
void pure_device() override {}
};

SYCL_EXTERNAL void test() {
Derived1 d1;
Base *b = nullptr;
if (rand())
b = &d1;
b->display();
}

Loading