-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][UR][L0] Fix issue with event caching causing profiling tag conflicts #16233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 5 commits into
intel:sycl
from
steffenlarsen:steffen/regression_profiling_tag_caching
Dec 10, 2024
Merged
[SYCL][UR][L0] Fix issue with event caching causing profiling tag conflicts #16233
steffenlarsen
merged 5 commits into
intel:sycl
from
steffenlarsen:steffen/regression_profiling_tag_caching
Dec 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flicts This commit adds a test and changes to a UR version that fixes an issue where the L0 would report old timestamp recordings for events produced for profiling tags, due to reusing of dead events. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
kbenzie
approved these changes
Dec 9, 2024
This was referenced Dec 9, 2024
Friendly ping @intel/llvm-reviewers-runtime | @KseniyaTikhomirova . |
KseniyaTikhomirova
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sycl/test-e2e/Regression/profiling_tag_cached_conflicting.cpp LGTM
KornevNikita
pushed a commit
that referenced
this pull request
Feb 25, 2025
…flicts (#16233) This commit adds a test and changes to a UR version that fixes an issue where the L0 would report old timestamp recordings for events produced for profiling tags, due to reusing of dead events. --------- Signed-off-by: Larsen, Steffen <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a test and changes to a UR version that fixes an issue where the L0 would report old timestamp recordings for events produced for profiling tags, due to reusing of dead events.