Skip to content

[SYCL][ESIMD][E2E] Fix ambiguity in device descriptor usages in ESIMD tests #16254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

againull
Copy link
Contributor

@againull againull commented Dec 3, 2024

Follow-up after #15905
These tests use using directive for both sycl and esimd namespaces and info is available in both, so we have to explicitly specify namespace in this case to avoid ambiguity.

Hasn't been noticed before because tests run only on pvc.

@againull againull requested a review from a team as a code owner December 3, 2024 22:09
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but do we know why it started failing now? did we add an include somewhere in the last PR or something?

also can you please add [ESIMD] after [SYCL] in the PR title?

@againull againull changed the title [SYCL][E2E] Fix ambiguity in device descriptor usages in ESIMD tests [SYCL][E2E][ESIMD] Fix ambiguity in device descriptor usages in ESIMD tests Dec 3, 2024
@againull againull changed the title [SYCL][E2E][ESIMD] Fix ambiguity in device descriptor usages in ESIMD tests [SYCL][ESIMD][E2E] Fix ambiguity in device descriptor usages in ESIMD tests Dec 3, 2024
@againull
Copy link
Contributor Author

againull commented Dec 3, 2024

lgtm but do we know why it started failing now? did we add an include somewhere in the last PR or something?

also can you please add [ESIMD] after [SYCL] in the PR title?

These tests didn't fail initially because they have "requires: pvc" and we don't build/run such tests in intel/llvm CI.

@sarnex
Copy link
Contributor

sarnex commented Dec 3, 2024

right, but i run testing manually on pvc somewhat often and i don't remember seeing this many failures. do we know why the previous PR was related?

@againull
Copy link
Contributor Author

againull commented Dec 3, 2024

right, but i run testing manually on pvc somewhat often and i don't remember seeing this many failures. do we know why the previous PR was related?

Before previous PR we had sycl::info and sycl::ext::intel::info namespaces. Previous PR also introduced info into sycl::ext::intel::esimd namespace. So, if both sycl and sycl::ext::intel::esimd are included by means of using directive then there is a name collision and we have to explicitly specify which info we want to use.

@sarnex
Copy link
Contributor

sarnex commented Dec 3, 2024

ok thanks that exactly answers my question!

@againull againull merged commit e5e77d4 into intel:sycl Dec 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants