[SYCL][HIP] add missing nearbyint and rint #16373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would leave review (and set my +1 after) to @jinge90 since libdevice is out of SYCL RT expertise |
jinge90
approved these changes
Dec 16, 2024
@intel/llvm-reviewers-runtime, should we fix the CODEOWNERS file? I would also review this change with the @MartinWehking, who added NVIDIA and AMD GPU support to libdevice. |
|
Thank you for the links. I have a question. Is there fp64 ? |
sorry, it's added now. |
|
No problem. Thanks. |
MoveCloudROY
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Please rerun the CI, :D |
MoveCloudROY
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
MoveCloudROY
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Yes, but I don't know who the owners should be... @jinge90 , can you make a PR for that? |
aelovikov-intel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to compile OneDNN using DPCPP on AMD with sycl because the code here that will run on the device actually calls
nearbyintfhere , butnearbyintflacks a symbolic definition.Same solution as #11177 but go straight to the
__ocmlsymbols