-
Notifications
You must be signed in to change notification settings - Fork 789
[SYCL] Set -O0 as the default SYCL device optimization if -g is passed #16408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esimd lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks.
// CHECK-G-O2: sycl-post-link{{.*}} "-O2" | ||
// CHECK-G-O2-NOT: "-O0" | ||
// CHECK-G-O3: clang{{.*}} "-fsycl-is-device{{.*}}" "-O3" | ||
// CHECK-G-O3: sycl-post-link{{.*}} "-O3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note - the -O2
to -O3
behavior is not in xmain, so some adjustments to the test will be needed when this is pulled down.
@intel/llvm-gatekeepers Hello, This is ready for merging. Thanks! |
Set
O0
as the default SYCL device optimization if-g
is passed and optimization level is not provided explicitly.Use of
'-g'
without any optimization-level option will turn off compiler optimizations similar to use of'-O0'
.