-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][E2E] Re-enable test case for exp(float) on win #16639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Waiting for #16950 |
The version of MSVC now is 14.43.34808. This code:
results in:
The result is correct, so this compiler should be OK. But the test case is still failing:
@jinge90 do you know what may be wrong? |
Let me take a look. |
Hi, @KornevNikita
I will narrow down to see whether it is a IGC issue. Thanks very much. |
For input '-0', __spirv_ocl_sin returns +0 for float and returns -0 for double, although no definition exists in standard for -0 input, MSVC complex math implementation does depend on this, discarding the signbit for sin(-0) will lead to some corner case failures in exp(std::complex<float>) e2e tests. This patch is a workaround for the issue.
This reverts commit 23da6b1.
Reverted Ge's commit, it's already in the sycl - #17440 |
@intel/llvm-gatekeepers could you please merge? |
The issue was fixed by #17440