[CI] Simplify nightly docker images #16680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have a single docker image created with all the dependencies pre-installed so that it could be used for all internal CI needs for every target. Other workflows should be changed after this is merged and new image is uploaded to the registry.
| @@ -78,7 +74,8 @@ development containers: | |||
| NVidia/AMD and can be used for building DPC++ | |||
| compiler from source with all backends enabled or for end-to-end testing | |||
| with HIP/CUDA on machines with corresponding GPUs available. | |||
|
|
|||
| - `devops/containers/nightly`: contains the latest successfully | |||
| built nightly build of DPC++ compiler. | |||
There was a problem hiding this comment.
Suggested change
| built nightly build of DPC++ compiler. | |
| built nightly build of DPC++ compiler, along with `latest` Intel drivers and NVidia/AMD development kits (same as `alldeps`). |
There was a problem hiding this comment.
I've done that on purpose. I'm planning to fuse tags for the base images as well, so that we'll only have 2204/2404/nightly images and once done that clarification will become irrelevant and even confusing.
There was a problem hiding this comment.
Sure, seems reasonable to me.
sarnex
approved these changes
Jan 17, 2025
|
@bader would you mind reviewing on behalf of the docs team? I need this merged to start working on the next step (modifying run-tests workflow). |
bader
approved these changes
Jan 17, 2025
aelovikov-intel
added a commit
that referenced
this pull request
Jan 18, 2025
Built on top of #16680.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 21, 2025
) Built on top of #16680.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 27, 2025
First step on unifying our "base" image into a single "fat" container similarly to what's been done with nightly images at #16680.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 28, 2025
First step on unifying our "base" image into a single "fat" container similarly to what's been done with nightly images at #16680.
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Apr 1, 2025
Those dockerfiles were previosly renamed on `sycl` branch in intel#16255 and intel#16680. When we synced `.github` and `devops` changes from `sycl` to `sycl-rel-6_1_0` in intel#17612, we copied over new versions, but did not delete the old ones and this PR does exactly that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a single docker image created with all the dependencies pre-installed so that it could be used for all internal CI needs for every target. Other workflows should be changed after this is merged and new image is uploaded to the registry.