Skip to content

[E2E] Update the current XFAIL status of e2e tests with the SPIR-V Backend #16692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

[E2E] Update the current XFAIL status of e2e tests with the SPIR-V Backend #16692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c552052
Update the current XFAIL status of e2e tests with the SPIR-V Backend
VyacheslavLevytskyy Jan 20, 2025
b92d66d
update XFAILs
VyacheslavLevytskyy Jan 27, 2025
1b61bb2
update XFAIL
VyacheslavLevytskyy Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sycl/test-e2e/DeprecatedFeatures/opencl_interop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
// RUN: %{build} -D__SYCL_INTERNAL_API -o %t.out %opencl_lib
// RUN: %{run} %t.out

// XFAIL: spirv-backend && cpu
// XFAIL-TRACKER: CMPLRLLVM-64705

#include <cassert>
#include <exception>
#include <sycl/detail/core.hpp>
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/GroupAlgorithm/load_store/conversions_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// XFAIL: spirv-backend && cpu
// XFAIL-TRACKER: CMPLRLLVM-64705

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/experimental/group_load_store.hpp>

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/MemorySanitizer/check_buffer_memset_memcpy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
// RUN: %{build} %device_msan_flags -O2 -g -o %t2.out
// RUN: %{run} %t2.out 2>&1 | FileCheck %s

// XFAIL: spirv-backend
// XFAIL-TRACKER: CMPLRLLVM-64705

#include <sycl/detail/core.hpp>

__attribute__((noinline)) int foo(int data1, int data2) {
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/MemorySanitizer/check_device_global.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
// RUN: %{build} %device_msan_flags -O2 -g -o %t3.out
// RUN: %{run} not %t3.out 2>&1 | FileCheck %s

// XFAIL: spirv-backend
// XFAIL-TRACKER: CMPLRLLVM-64705

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/device_global/device_global.hpp>
#include <sycl/usm.hpp>
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/MemorySanitizer/check_usm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
// UNSUPPORTED: cpu
// UNSUPPORTED-TRACKER: CMPLRLLVM-64618

// XFAIL: spirv-backend && gpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this test can work well on "spirv-backend && cpu"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, right, the test case works on cpu but not on gpu. I haven't had a capacity yet to look any closer to a newer e2e test cases, including Memory Sanitizer. It should be very easy for you to look what's the issue, if we are lucky it can be as simple, for example, as CHECK-DAG instead of CHECK. After recent PR's it's easy to switch between Translator and Backend in your local dev environment and reproduce the case. Please let me know if I can help!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will take a look

// XFAIL-TRACKER: CMPLRLLVM-64705

#include <sycl/detail/core.hpp>
#include <sycl/usm.hpp>

Expand Down
4 changes: 0 additions & 4 deletions sycl/test-e2e/Reduction/reduction_nd_N_vars.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows

// Depends on SPIR-V Backend & run-time drivers version.
// XFAIL: spirv-backend && gpu
// XFAIL-TRACKER: CMPLRLLVM-64705

// This test checks handling of parallel_for() accepting nd_range and
// two or more reductions.

Expand Down
Loading