-
Notifications
You must be signed in to change notification settings - Fork 788
[CI] Temporarily disable tests requiring spirv-tools
in CI
#16743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock fixing CI failures, but llvm-spirv
changes should either be upstreamed, or tracked in #7592 to remind us to revert them
I'm okay with merging this to fix post-commit. About the root cause, the problem seems to be that the path for all spirv-tools binaries is not found:
I'm not sure why, I cannot reproduce locally. If you help me reproduce the issue, I can try and fix it. |
Co-authored-by: Marcos Maronas <[email protected]>
spriv-tools
in CIspirv-tools
in CI
@intel/llvm-gatekeepers I think we are good to merge this. |
Hi @maarquitos14, @intel/dpcpp-spirv-reviewers, So, in
The installation package does not have the correct CMake target import file. Here's the import files
Notice the Solution: PS:- I've installed |
@uditagarwal97 Thanks for the thorough investigation! I'm good with the suggested solution, let me know if you need any help. |
`pkg-config` is required for `llvm-spirv` to detect `spirv-tools` installation. See #16743 (comment) for more info.
…#16801) Reverts #16743. After installing `pkg-config` in CI, `llvm-spirv` can correctly find `spriv-tools` so this workaround is no longer needed. Example run: https://github.com/intel/llvm/actions/runs/12996166493/job/36244369469?pr=16801#step:14:16
#16724 installed
spirv-tools
on Linux docker containers and now some llvm-spirv tests are failing due to this (example: https://github.com/intel/llvm/actions/runs/12915358763/job/36017038536).In this PR, we disable detection of
spirv-tools
LIT feature temporarily in CI to fix post-commit.