Fix some uninitialized pointer usage in Driver #1683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinge90
force-pushed
the
fix_uinitialized_ptr_use_driver
branch
from
826b84f to
67228b5
Compare
AGindinson
suggested changes
May 13, 2020
|
A |
jinge90
force-pushed
the
fix_uinitialized_ptr_use_driver
branch
from
67228b5 to
c3569b5
Compare
The tag is added. Thank you for kind remind. |
jinge90
force-pushed
the
fix_uinitialized_ptr_use_driver
branch
from
c3569b5 to
872ae70
Compare
Signed-off-by: gejin <[email protected]>
AGindinson
approved these changes
May 13, 2020
mdtoguchi
approved these changes
May 13, 2020
Fznamznon
pushed a commit
to Fznamznon/llvm
that referenced
this pull request
Nov 8, 2022
One of the reasons behind this change is to make code more easily deal with the
future prospect of opaque types, so that helper methods (like adjusting image
types) can handle both pointer type and opaque type representations simply by
querying if the input type is a TypedPointerType or an OpaqueType [name for the
latter still pending].
The set of changes are:
* OCLTypeToSPIRV now uses TypedPointerType internally
* adaptSPIRVImageType and getSPIRVStructTypeByChangeBaseTypeName are collapsed
into one method (adjustImageType) that works with TypedPointerTypes.
* A few is*StructType methods have been reverted back to is*Type methods, taking
a TypedPointerType parameter instead.
* BuiltinCallHelper::addSPIRVCall{Pair} allows for the creation of SPIR-V calls
that can use TypedPointerType or actual type for parameters and return value.
* BuiltinCallHelper::getCallValue{Type} is a simple helper that hides many of
the uses of getParameterTypes.
* The Type* parameter of the callback in BuiltinCallMutator::mapArg now provides
a TypedPointerType or the actual type, instead of the pointer element type.
* BuiltinCallMutator::ValueTypePair similarly takes a TypedPointerType or the
actual type.
* getParameterTypes (when passed a SmallVector<Type *>) does a similar thing.
(The SmallVector<TypedPointerType *> variant has been removed in favor of only
using the other one.)
Note that the last few changes do change the semantics of function parameters
without changing the function name or signature.
Co-authored-by: Dmitry Sidorov <[email protected]>
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@5ce6a99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gejin [email protected]