Skip to content

[SYCL][Matrix][E2E] Mark AMD/NVIDIA build targets as unsupported for some Matrix tests #16855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jan 31, 2025

Adds UNSUPPORTED: target-nvidia, target-amd to matrix tests that also require aspect-ext_intel_matrix since these tests are not yet supported for those triples.

@ayylol ayylol requested a review from a team as a code owner January 31, 2025 14:14
@dkhaldi
Copy link
Contributor

dkhaldi commented Jan 31, 2025

since these tests do not build for any triples other than spir64

The tests can also build for specific target values like intel_gpu_pvc

@ayylol
Copy link
Contributor Author

ayylol commented Jan 31, 2025

since these tests do not build for any triples other than spir64

The tests can also build for specific target values like intel_gpu_pvc

Would it be preferable to mark these instead with UNSUPPORTED: target-amd, target-nvidia, target-native_cpu? Those are the triples that i tested that didn't build.

Also curious, how are we currently testing for the other specific target values that you mention?

@ayylol
Copy link
Contributor Author

ayylol commented Feb 6, 2025

@intel/sycl-matrix-reviewers @dkhaldi Hey, just wanted to continue this conversation regarding this pr, given that #16813 is dependent on the changes here.

@dkhaldi
Copy link
Contributor

dkhaldi commented Feb 6, 2025

since these tests do not build for any triples other than spir64

The tests can also build for specific target values like intel_gpu_pvc

Would it be preferable to mark these instead with UNSUPPORTED: target-amd, target-nvidia, target-native_cpu? Those are the triples that i tested that didn't build.

I think that will be better as it really captures the real situation.
Just to double check, target-native_cpu means bypassing SPIRV right?

Also curious, how are we currently testing for the other specific target values that you mention?

We are not testing today for the specific target values as we don't specify any AOT. We only do jit compilation for these tests.

@ayylol
Copy link
Contributor Author

ayylol commented Feb 6, 2025

I think that will be better as it really captures the real situation.

Ok, I've done that. There was one test that was failing to build for nvptx, which required gpu-intel-gen12 so I left the requirement as target-spir for it.

Just to double check, target-native_cpu means bypassing SPIRV right?

From what I know it is a different triple, so yes it wouldnt be spir. Though I dont currently have plans to enable that for the split build/run in CI so I omitted it.

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayylol ayylol changed the title [SYCL][Matrix][E2E] Add target-spir requirement to matrix tests [SYCL][Matrix][E2E] Mark AMD/NVIDIA build targets as unsupported for some Matrix tests Feb 7, 2025
@againull againull merged commit 1e3940b into intel:sycl Feb 7, 2025
16 checks passed
@ayylol ayylol deleted the matrix-spir branch February 10, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants