-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Matrix][E2E] Mark AMD/NVIDIA build targets as unsupported for some Matrix tests #16855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The tests can also build for specific target values like intel_gpu_pvc |
Would it be preferable to mark these instead with Also curious, how are we currently testing for the other specific target values that you mention? |
I think that will be better as it really captures the real situation.
We are not testing today for the specific target values as we don't specify any AOT. We only do jit compilation for these tests. |
Ok, I've done that. There was one test that was failing to build for nvptx, which required
From what I know it is a different triple, so yes it wouldnt be spir. Though I dont currently have plans to enable that for the split build/run in CI so I omitted it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
target-spir
requirement to matrix tests
Adds
UNSUPPORTED: target-nvidia, target-amd
to matrix tests that also requireaspect-ext_intel_matrix
since these tests are not yet supported for those triples.